Allow selection of initial years to not require/read full range from MIN-MAX start years#248
Merged
Merged
Conversation
andrewbaxter439
requested review from
AndreasxHoehn,
Copilot,
igelstorm and
justin-ven
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to selectively load initial population data for specific years instead of loading the full range defined by MIN_START_YEAR and MAX_START_YEAR parameters. This optimization aims to save time and memory when only certain years are needed for simulation.
- Added
includeYearsparameter to allow selective year loading - Modified DataParser to support year-specific population initialization
- Updated configuration file to include example usage of the new feature
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/simpaths/data/startingpop/DataParser.java | Added new overloaded method and conditional logic to use includeYears when specified |
| src/main/java/simpaths/data/Parameters.java | Added static field to store the includeYears configuration |
| config/default.yml | Added commented example configuration for the includeYears parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential fix for closing #229
What
initialYearsin config file.Why
MIN_START_YEARandMAX_START_YEARin Parameters.javaHow
In a configuration file, specify:
Check defaut.yml for range of potential sample years.